reacton icon indicating copy to clipboard operation
reacton copied to clipboard

feat: relax typing_extensions version constraint

Open egormkn opened this issue 1 year ago • 1 comments

Hello! I wanted to use Reacton in a project where the version of typing_extensions is pinned to 3.7.4.1 (python3-typing-extensions package from Ubuntu 20.04). However, due to ParamSpec usage, reacton requires at least 4.1.1. I suggest to relax the requirements, as missing type definition does not break anything.

Here I used a simple try-except to set type alias to ellipsis on failed import. Not entirely sure if it is correct as documentation specifies a literal ellipsis as a possible type argument for Callable, but with CPython 3.6+ this works fine.

egormkn avatar Jul 22 '24 11:07 egormkn

@egormkn Sorry for taking so long, I missed this one. Do you still need this?

maartenbreddels avatar Dec 13 '24 12:12 maartenbreddels