wger-project
Improve variations widget for new exercises
The variations widget used to inform the user that the exercise might already exist in the database needs a bit of polishing so that it works like the one used in the web application:
- [ ] allow to filter the list by name
- [ ] group exercises that are together so that it's clear that they form a "group"
- [ ] add the missing info text
Flutter version
Web version:
I wish to contribute to this problem kindly allow me to work on this issue.
The help text at the bottom is "If you notice an exercise that is identical to the one you're adding, please discard your draft and edit that exercise instead.", on the search box "enter exercise name to filter variations"
I am facing few difficulties to understand this issue need your guidance.
- You want me to add a filter to select by name in this variations part
- For second task, should I make group having name and then they will expand and show variations, for example:- variation section will have groups of different variations and then after opening those groups we will find main variation (variation section -> group -> variations ) can I make it in this way.
- In last task what do you exactly mean by missing info text? Is this a text which I should add at last of variations just like we see others when there is no match in list
- exactly
- Yes, so exercises can have variations (like e.g. curls with dumbbells, curls with barbell, curls on the machine, etc.) and when the user adds a new exercise, it should be possible to add it to one of the existing groups. That is this whole widget. All the exercises that are variations of each other are then one group which the user should be able to select. These groups can contain from two or three to more than a dozen exercises, so we can't just show the images for all of them, in the react app we show the first three images and can expand the list with the name of the exercises
- I meant the info text at the bottom next to the button, I hadn't noticed that I had posted a screnshot in German
- Please guide me from where I can retrieve list of variations UI wise it is complete need to add functionality
- will be working on this soon
- Is this what you want? kindly check in above image
any suggestions?
- There are two lists for this, the exercises that already have variations (those groups we were talking about) and exercises which currently don't belong to any group. In the widget you can see how they are retrieved, the lines with
...exerciseProvider.exerciseBasesByVariation.keysand...exerciseProvider.bases(we sadly need to differentiate between them because the logic in the backend is different, but you only need to change the UI for the exercises with variations) - sure, not problem!
- yes, that's great
- So do I need to add filter functionality too or just need to add it in UI.
- Can you please explain more that how can I group them like on what basis and from where should I retrieve that data.
- completed
Implementing the actual filtering filtering would be great, yes
As for grouping, I would just take the first n images (depending on how this would be presented, we don't have so much space as on the web version), you can just use the getMainImage getter on exercisebase. And besides that some amount of names so that the user can get an idea of what kind of exercises are. In the react version we show the first 5 plus some ... to indicate that there are more, if the user hovers over the ellipsis, the list expands completely (while this would be nice to have, just showing the first 5 or so, again, depending on the design, would be enoug)