flutter icon indicating copy to clipboard operation
flutter copied to clipboard

Add simple WYSIWYG editor for exercise descriptions

Open rolandgeider opened this issue 3 years ago • 10 comments

Exercise descriptions are currently HTML, so the user should be able to edit it as well. This HTML is cleaned server side when saving, only the following tags are allowed: 'b', 'i', 'strong', 'em', 'ul', 'ol', 'li', 'p'

rolandgeider avatar Jun 20 '22 18:06 rolandgeider

Hi, I would like to try resolve this issue, could you assign me?

sandimilohanic avatar Oct 04 '22 15:10 sandimilohanic

It's yours :)

This is also in the exercise crowdsourcing branch, like the other issue with the translations

rolandgeider avatar Oct 04 '22 15:10 rolandgeider

BTW, you can reach the form from the workout tab -> top right menu -> contribute exercise in the description step

rolandgeider avatar Oct 04 '22 16:10 rolandgeider

This was also merged into master in the meantime btw

rolandgeider avatar Oct 14 '22 13:10 rolandgeider

@rolandgeider can I use this package https://pub.dev/packages/markdown_editable_textinput as a WYSIWYG editor and configure it ?

sandimilohanic avatar Oct 18 '22 06:10 sandimilohanic

Sadly we need HTML for the description. We've been thinking of also allowing to store markdown in the description, but this would need some changes in the backend as well

rolandgeider avatar Oct 18 '22 10:10 rolandgeider

Sadly we need HTML for the description. We've been thinking of also allowing to store markdown in the description, but this would need some changes in the backend as well

Sorry, I sent you wrong package, I mean this one https://pub.dev/packages/html_editor_enhanced

sandimilohanic avatar Oct 18 '22 10:10 sandimilohanic

ah, yes, better 😄

Sure, go ahead

rolandgeider avatar Oct 18 '22 11:10 rolandgeider

hi @Radiant690 , thanks for asking, but there is already a PR for this (just linked it so it's more obvious)

rolandgeider avatar Feb 07 '23 12:02 rolandgeider

I just saw that the description field is currently disabled, do you want to take a look @Radiant690 ? I've pulled the branch and solved the current merge conflicts to feature/wysiwyg-description

rolandgeider avatar Feb 08 '23 11:02 rolandgeider