wfxr
Add variable FORGIT_ENTER_PAGER
Check list
- [x] I have performed a self-review of my code
- [x] I have commented my code in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
Description
The pager used on fzf enter key binding commands was hardcoded to LESS='-r' less. Transfer this to a variable in order to reduce code duplication and make it configurable.
Since the other pager variables were not part of the documentation I did not add this new variable either.
Type of change
- [ ] Bug fix
- [x] New feature
- [x] Refactor
- [ ] Breaking change
- [ ] Documentation change
Test environment
- Shell
- [x] bash
- [ ] zsh
- [x] fish
- OS
- [x] Linux
- [ ] Mac OS X
- [ ] Windows
- [ ] Others:
Sorry for the delay!! Crazy week at work. I’ll definitely take a look this weekend at both of your new changes 😀
On Mon, Aug 1, 2022 at 4:42 AM, Tim @.***> wrote:
Check list
- I have performed a self-review of my code
- I have commented my code in hard-to-understand areas
- I have made corresponding changes to the documentation
Description
The pager used on fzf enter key binding commands was hardcoded to LESS='-r' less. Transfer this to a variable in order to reduce code duplication and make it configurable.
Since the other pager variables were not part of the documentation I did not add this new variable either.
Type of change
- Bug fix
- New feature
- Refactor
- Breaking change
- Documentation change
Test environment
Shell
bash
zsh
fish
OS
Linux
Mac OS X
Windows
Others:
You can view, comment on, or merge this pull request online at:
https://github.com/wfxr/forgit/pull/225
Commit Summary
- 25e1a2e Add variable FORGIT_ENTER_PAGER
File Changes
(2 files)
- M conf.d/forgit.plugin.fish (8)
- M forgit.plugin.zsh (7)
Patch Links:
- https://github.com/wfxr/forgit/pull/225.patch
- https://github.com/wfxr/forgit/pull/225.diff
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>
