speccy icon indicating copy to clipboard operation
speccy copied to clipboard
verified publisher icon wework

Glob pattern for lint command

Open AnianZ opened this issue 7 years ago • 4 comments

I tried to solve the problem posed in #118. It's now possible to lint multiple files with glob patterns supported by https://github.com/isaacs/node-glob. Additional to that I also pulled in https://github.com/micromatch/is-glob to check if the parameter the user supplied is a glob pattern or a filename.

This is my first PR which changes the actual code of the repo so I wanted to get it out as soon as possible to get your feedback and see if I'm on the right path. The globbing works and I tested it with a few example cases on my machine. Possible improvements would be more error handling if your glob pattern does for example return directories and probably more unit tests.

Please inform me if something important is missing or if should change the way it's implemented.

AnianZ avatar Oct 31 '18 20:10 AnianZ

Coverage Status

Coverage decreased (-0.8%) to 87.08% when pulling 9dd944c1f489d2ceb51d597b956c459cc10c06e9 on AnianZ:master into 4bb0a626138a7673456a2de15070637db560adde on wework:master.

coveralls avatar Oct 31 '18 20:10 coveralls

Coverage Status

Coverage decreased (-0.8%) to 87.08% when pulling 0b1116eea35380dde695edd95fd2d3485dde4e1f on AnianZ:master into 200868445a5cde0376029898353eab500e9ca62a on wework:master.

coveralls avatar Oct 31 '18 20:10 coveralls

Coverage Status

Coverage decreased (-0.8%) to 87.08% when pulling 9dd944c1f489d2ceb51d597b956c459cc10c06e9 on AnianZ:master into 4bb0a626138a7673456a2de15070637db560adde on wework:master.

coveralls avatar Oct 31 '18 20:10 coveralls

You'll probably want to squash the multiple commits in this MR :sweat_smile:

AnianZ avatar Oct 31 '18 20:10 AnianZ