flex icon indicating copy to clipboard operation
flex copied to clipboard

Issue when compiling with >= C++11 and -Werror,-Wsuggest-override

Open emcrisostomo opened this issue 4 years ago • 3 comments

As you can see in this MacPorts ticket, lilypond is failing to compile because an error is raised because of FlexLexer.h not using the override specifier on overridden class member declarations.

https://trac.macports.org/ticket/62801

emcrisostomo avatar May 29 '21 09:05 emcrisostomo

Thanks! I read the issue over at macports.

A couple of PRs in the pipe will make fixing this a lot easier by separating the output language generation into separate skeletons. Right now, a ton of C emissions are built into the code. Even generating C++ is a kludge.

Until we finish separating the code emitters, treat the included FlexLexer.h as a template. If it doesn't fit your needs or your version of C++ make your own copy of it.

Down the line, we'll be able to make a C++11 version of the C++ skeleton that will let you use all the new language features. If you want to make a head start on that take a look at #460.

Mightyjo avatar May 29 '21 17:05 Mightyjo

Thank you very much @Mightyjo, I'll have a look at #460. As far as that port is concerned, treating FlexLexer.h as a template should work easily.

emcrisostomo avatar May 29 '21 19:05 emcrisostomo

The retargeting patch series has been merged in, albeit under a different set. Do you still have this problem against master?

westes avatar Jul 08 '21 00:07 westes