Simone Carletti

Results 82 comments of Simone Carletti

+1 I love the `do not rescue Exception unless you really mean it` paragraph!

This is an interesting point. I personally suggest to avoid one-line definition, even if methods are empty like the case of very simple Rails controllers. The only situation where one-line...

> Firstly, I feel that crossing out the word "monkeypatch" and having "hack" as a crossed-out term also makes the document a little personal. This should be an educational document...

I agree. This is something I would have done a while ago.

Tracking internally as feature request.

> Or perhaps flipped to be `namespace: "sidekiq.my-app"` instead? Better the format `.` as most likely you care to aggregate by app first. This is best described in the point...

I used the recommended setup in the Agent. I set `namespace: "sidekiq"` in the `Datadog::Statsd` instance, then used the mapper to rewrite `sidekiq.sidekiq` entries (line 1 of 3). The mappers...

> @weppos thank you. That's most helpful. A final clarification, Did you happen to only have one Sidekiq running or multiple Sidekiq's for different apps? I'm guessing the former as...

Do you mind to elaborate a bit what changes are being implemented in 8.0? Do you add `sidekiq.*` in front of every sidekiq name?

> Should there be a common prefix for all Sidekiq-sourced metrics? I think so. Looking at my DD account, I see that each service has its own default prefix. So...