Ruby-SDK icon indicating copy to clipboard operation
Ruby-SDK copied to clipboard
verified publisher icon wepay

Refactor `WePay::Client`

Open Fosome opened this issue 9 years ago • 5 comments

Refactor WePay::Client to use request objects:

  • WePay::TestRequest
  • WePay::ProductionRequest

This paves for more configuration - hopefully making web/net adapter libs configurable:

  • Net:HTTP (default)
  • Patron
  • Typheous
  • HTTParty
  • etc.

Fosome avatar Jun 13 '16 18:06 Fosome

Coverage Status

Changes Unknown when pulling c6a83b9caef99b8d75335f42da7b186921e97b7d on Fosome:client-request-response into * on wepay:master*.

coveralls avatar Jun 13 '16 18:06 coveralls

@skyzyx Feels?

Fosome avatar Jun 15 '16 19:06 Fosome

Follow up here: https://github.com/Fosome/Ruby-SDK/pull/1

Fosome avatar Jun 16 '16 16:06 Fosome

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 15 '19 19:08 CLAassistant

@Fosome sign the CLA? Code looks great.

calebhaye avatar Dec 18 '20 23:12 calebhaye