Eduardo Weidman Barijan

Results 21 comments of Eduardo Weidman Barijan

> My thoughts are that we should just avoid all of the extra complexity added here and just add extra handling to the system error handler to adjust the message...

> I have an issue when adding the form (via repeater) the buttons touchspin-up and touchspin-down are not working. Does it work for you ? > The code you've mentioned...

I noticed the same problem with Laravel 7 and latest Voyager. I will take a look on how the table is created because I think it is just a matter...

> Monetary values shouldn't be stored in floating-point numbers anyway (https://spin.atomicobject.com/2014/08/14/currency-rounding-errors/. it's a bit old, but the points are still relevant) That is correct, but the decimal field is not...

Ah! I get it. Yes, the value will be treated as a float by internal conversion of PHP. But in the actual code you should never round the values, just...

> Yes, but what variable does that value go into when it gets pulled out of the database...? I have been thinking and maybe it is our approach that is...

@MrCrayon oh you are right! I always forget we can do operation with cents and it makes sense to store the value as integer and doing visual transformations for display....

> It seems the fix is causing bigger issues see #26, falling back until a better solution is found. Oh my! That is not good. The extension was working fine....

I noticed the same issue on my project. I use groups with namespaces and the extension gets only the Admin controllers, because the controllers have the same name but are...

> Unfortunately I don't have time to work on this feature, PRs are always welcomed. Well that is my cue to learn Typescript and VSCode extension development. I would love...