Thomas Zoechling

Results 35 comments of Thomas Zoechling

Hi, Resource forks are currently unsupported. I will leave this issue open and attach a "Help Wanted" label. Maybe someone wants to contribute a PR.

> Extracting zip file is failing intermittently on latest release i.e 0.9.18. I was able to unzip with previous releases. Do the archives you are trying to unzip contain symlinks...

I just merged PR #263 into `development`. The changes there make symlink sorting obsolete and also fix all problems that were addressed by this PR. Thanks to @JosephDuffy for providing...

Hi Luke, Thanks for investigating. I just skimmed over the changes and on a first glance, this change here could be the source of the performance degradation: https://github.com/weichsel/ZIPFoundation/commit/b3ca1e6f050a26b6232d70fe04937bf2a7c282ba#diff-d829f12a7b0fa38c616a3397c9ea1464287b0d0097dee344876fff88b4b28e39L316 Currently don't...

ZIP Foundation currently doesn't support splitting ZIP files. If you can provide a PR that implements this feature (as outlined in section 8.0 of the ZIP APPNOTE: https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT), I can...

Thanks for looking into this issue. There seem to be archives that require those `size > 0` safe guards though (e.g. `testExtractCompressedZIP64Entries` fails for me). I haven't looked into the...

> How do you create testExtractCompressedZIP64Entries.zip? It doesn't look like a valid ZIP64 file. macOS can unzip it, but testing the archive reveals issues: The ZIP64 support was provided by...

Thanks! Very good catch - I also wasn't aware of `loadUnaligned`.

> Any ideas how to fix the linting? Please pull in `development` - I already fixed those warnings there.

Thanks for providing this PR. I like the idea of using truncate as fast-path when possible but I wonder if it wouldn't be better to keep that an implementation detail....