Upgrade to tailwindcss 4.0
Perhaps should upgrade DaisyUI since tailwindcss is a dependency?
Hi! Can I take this issue? I'm not familiar with tailwind or DaisyUI but I've already started reading up on how to upgrade. Any pointers help but if not no worries.
@aleguy02 assigned, much appreciated!
Upgrading to v4 changed the look of some components/utilities (for instance, bg-neutral on the repo input is darker now). Lmk, I could try manually editing them until they match the live site but they might not fully pass the e2e tests.
Also, v4 renamed some utilities so some of the snapshots may need to be updated.
I am running into an issue where the scale-125 in the GitHub svg isn't showing up on the site (the svg stays the same size) but have found a temporary workaround by creating a custom utility class. It seems like there is an issue with styles conflicting so I'm doing some reading on how to address this
Edit: changed message for specificity and to reflect new temporary fix
DaisyUI upgrade changed a lot of component's visuals, I fixed some minor visual bugs but can't pass the tests. Let me know how to approach updating snapshots @wei @CryogenicPlanet
Following up on this @wei @CryogenicPlanet
Thanks for the bump! I'm returning from my trip next week and will have some time to review the pr 😊
@aleguy02 I am open to have styles slightly different after the upgrade as long as they look nice. I'd start with using standard utility classes instead of creating new custom style overrides and decide from there. Please post a few before and after screenshots for approval and collect feedback as you work on them. TY!
alrighty will do, I have exams next week, and my technical interview for MLH ;), so I'll get started after that
Good luck @aleguy02 !!
Thanks! I'm hoping it went well. Anyways, I made this Google Doc with before/after images of affected screens. I will add more screens as I fix them up, but now you should be able to see progress so far and suggest feedback.
@aleguy02 all looks great, some of the colors and padding on the input and the action buttons need minor adjustment but overall looking amazing! 🔥
@aleguy02 Just checking in to see if you're planning to create a PR in the near future. 😊
Yes, I was moving and getting settled the last couple of weeks, I'm aiming to create a PR this week
Excellent @aleguy02 ! Just to note we have upgraded all the packages except for tailwind and daisy. Be sure to pull in the latest 😊