socialify icon indicating copy to clipboard operation
socialify copied to clipboard

Upgrade to tailwindcss 4.0

Open wei opened this issue 1 year ago • 16 comments

Perhaps should upgrade DaisyUI since tailwindcss is a dependency?

wei avatar Jan 23 '25 13:01 wei

Hi! Can I take this issue? I'm not familiar with tailwind or DaisyUI but I've already started reading up on how to upgrade. Any pointers help but if not no worries.

aleguy02 avatar Jan 31 '25 04:01 aleguy02

@aleguy02 assigned, much appreciated!

wei avatar Jan 31 '25 09:01 wei

Upgrading to v4 changed the look of some components/utilities (for instance, bg-neutral on the repo input is darker now). Lmk, I could try manually editing them until they match the live site but they might not fully pass the e2e tests.

aleguy02 avatar Feb 08 '25 02:02 aleguy02

Also, v4 renamed some utilities so some of the snapshots may need to be updated.

aleguy02 avatar Feb 08 '25 02:02 aleguy02

I am running into an issue where the scale-125 in the GitHub svg isn't showing up on the site (the svg stays the same size) but have found a temporary workaround by creating a custom utility class. It seems like there is an issue with styles conflicting so I'm doing some reading on how to address this

Edit: changed message for specificity and to reflect new temporary fix

aleguy02 avatar Feb 23 '25 17:02 aleguy02

DaisyUI upgrade changed a lot of component's visuals, I fixed some minor visual bugs but can't pass the tests. Let me know how to approach updating snapshots @wei @CryogenicPlanet

aleguy02 avatar Feb 23 '25 19:02 aleguy02

Following up on this @wei @CryogenicPlanet

aleguy02 avatar Mar 26 '25 21:03 aleguy02

Thanks for the bump! I'm returning from my trip next week and will have some time to review the pr 😊

wei avatar Mar 27 '25 02:03 wei

@aleguy02 I am open to have styles slightly different after the upgrade as long as they look nice. I'd start with using standard utility classes instead of creating new custom style overrides and decide from there. Please post a few before and after screenshots for approval and collect feedback as you work on them. TY!

wei avatar Apr 15 '25 16:04 wei

alrighty will do, I have exams next week, and my technical interview for MLH ;), so I'll get started after that

aleguy02 avatar Apr 18 '25 15:04 aleguy02

Good luck @aleguy02 !!

wei avatar Apr 22 '25 20:04 wei

Thanks! I'm hoping it went well. Anyways, I made this Google Doc with before/after images of affected screens. I will add more screens as I fix them up, but now you should be able to see progress so far and suggest feedback.

aleguy02 avatar Apr 27 '25 17:04 aleguy02

@aleguy02 all looks great, some of the colors and padding on the input and the action buttons need minor adjustment but overall looking amazing! 🔥

wei avatar Jun 07 '25 22:06 wei

@aleguy02 Just checking in to see if you're planning to create a PR in the near future. 😊

wei avatar Jun 21 '25 19:06 wei

Yes, I was moving and getting settled the last couple of weeks, I'm aiming to create a PR this week

aleguy02 avatar Jun 25 '25 23:06 aleguy02

Excellent @aleguy02 ! Just to note we have upgraded all the packages except for tailwind and daisy. Be sure to pull in the latest 😊

wei avatar Jun 26 '25 01:06 wei