Wei He

Results 166 comments of Wei He

Thanks for the bump. Will review and try to merge it soon.

Hi I commented on 656cd1a, not the PR.

Perhaps we can use something like this to check the validity of the variable names: https://github.com/shinnn/is-var-name/blob/master/index.js

Hi @Fdawgs thanks for opening the issue. Pull app automates the creation of prs but does not request or have permission to manage the workflow runs. I recommend revising workflow...

Hi, the pull app itself is working fine. Endpoints are down because the gateway machine was not renewed. It will come back online once I buy and set up another...

I'd be happy to take a look if you would like to provide the repo you installed the app on~

Thanks for your message. Due to the endpoint being down, webhook events of new installations were not captured. I'm triggering a manual sync for now~ You should see it work...

There is currently an open PR for this https://github.com/repo-sync/pull-request/pull/89

It seems to be working in https://github.com/Telefonica/mistica-icons/blob/8ece560530b0277eb0bd41aaddfc507d9ddf3dae/.github/workflows/figma-export.yml#L284-L286 Example PR: https://github.com/Telefonica/mistica-icons/pull/233 Can you wrap it with quotes similar to the one in the comment?

@krtschmr Here is a another simple working example: Code: https://github.com/wei/test-pr/blob/15f57cc1439fde8185f60a4cd3455c6a0c1a7e1b/.github/workflows/pr.yml#L17-L20 Pull Request: https://github.com/wei/test-pr/pull/11 I don't know how your string is constructed I recommend reading more about how yml treats your...