Fix browser navigation button usage in QA review
Resolves #1759
Changes
Enables passing option to replace history state in navigate.to.
Manual testing
- Log in as crawler
- Navigate to archived item QA review
- Click browser "back" button. Verify QA tab loads as expected
- Click browser "forward" button. Verify QA review page loads
Hm, still seeing the back button needs to be pressed twice after clicking 'Review Crawl' to get back to the crawl details page.
Hm, still seeing the back button needs to be pressed twice after clicking 'Review Crawl' to get back to the crawl details page.
I'm not able to replicate that with any of my crawls, could you link me to the crawl where you're seeing the issue?
Hm, still seeing the back button needs to be pressed twice after clicking 'Review Crawl' to get back to the crawl details page.
I'm not able to replicate that with any of my crawls, could you link me to the crawl where you're seeing the issue?
Sure, I think it happens for every crawl if loading with #qa directly, and then clicking on Review crawl, eg:
http://localhost:9870/orgs/default-org/items/crawl/manual-20240426120823-f9ad1cc0-7f9#qa (with dev cluster)
Though, it's not 100% either, definitely happens on 2nd time going back, forward, back. It's not too big a deal, just thinking if there might be a quick fix (some race condition on history state?)
Though, it's not 100% either, definitely happens on 2nd time going back, forward, back. It's not too big a deal, just thinking if there might be a quick fix (some race condition on history state?)
I can consistently replicate it now, looks like a race condition with the iframe/rwp load effecting window history.