browsertrix icon indicating copy to clipboard operation
browsertrix copied to clipboard

Fix browser navigation button usage in QA review

Open SuaYoo opened this issue 1 year ago • 5 comments

Resolves #1759

Changes

Enables passing option to replace history state in navigate.to.

Manual testing

  1. Log in as crawler
  2. Navigate to archived item QA review
  3. Click browser "back" button. Verify QA tab loads as expected
  4. Click browser "forward" button. Verify QA review page loads

SuaYoo avatar May 01 '24 02:05 SuaYoo

Hm, still seeing the back button needs to be pressed twice after clicking 'Review Crawl' to get back to the crawl details page.

ikreymer avatar May 01 '24 23:05 ikreymer

Hm, still seeing the back button needs to be pressed twice after clicking 'Review Crawl' to get back to the crawl details page.

I'm not able to replicate that with any of my crawls, could you link me to the crawl where you're seeing the issue?

SuaYoo avatar May 06 '24 17:05 SuaYoo

Hm, still seeing the back button needs to be pressed twice after clicking 'Review Crawl' to get back to the crawl details page.

I'm not able to replicate that with any of my crawls, could you link me to the crawl where you're seeing the issue?

Sure, I think it happens for every crawl if loading with #qa directly, and then clicking on Review crawl, eg: http://localhost:9870/orgs/default-org/items/crawl/manual-20240426120823-f9ad1cc0-7f9#qa (with dev cluster)

ikreymer avatar May 07 '24 14:05 ikreymer

Though, it's not 100% either, definitely happens on 2nd time going back, forward, back. It's not too big a deal, just thinking if there might be a quick fix (some race condition on history state?)

ikreymer avatar May 07 '24 14:05 ikreymer

Though, it's not 100% either, definitely happens on 2nd time going back, forward, back. It's not too big a deal, just thinking if there might be a quick fix (some race condition on history state?)

I can consistently replicate it now, looks like a race condition with the iframe/rwp load effecting window history.

SuaYoo avatar May 07 '24 17:05 SuaYoo