webpack
webpack copied to clipboard
refactor: getTypes in asset/css generator
What kind of change does this PR introduce?
Refactor the getTypes logic to exclude generation when the original module is not an official JavaScript or CSS module.
Did you add tests for your changes?
Exists now but feel free to ask more
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No
CodSpeed Performance Report
Merging #19573 will degrade performances by 74.28%
Comparing hai-x:refactor-get-types (ccd5c41) with main (19ca741)
Summary
โก 81 improvements
โ 3 regressions
โ
37 untouched benchmarks
๐ 12 new benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmarks breakdown
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| โก | benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
42.1 ms | 34.3 ms | +22.8% |
| โก | benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
52.3 ms | 11.6 ms | ร4.5 |
| ๐ | benchmark "lodash", scenario '{"name":"mode-development","mode":"development"}' |
N/A | 755.8 ms | N/A |
| ๐ | benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
N/A | 30.2 ms | N/A |
| ๐ | benchmark "lodash", scenario '{"name":"mode-production","mode":"production"}' |
N/A | 9.8 s | N/A |
| ๐ | benchmark "many-chunks-commonjs", scenario '{"name":"mode-development","mode":"development"}' |
N/A | 248.4 ms | N/A |
| ๐ | benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
N/A | 9.8 ms | N/A |
| ๐ | benchmark "many-chunks-commonjs", scenario '{"name":"mode-production","mode":"production"}' |
N/A | 2 s | N/A |
| ๐ | benchmark "many-chunks-esm", scenario '{"name":"mode-development","mode":"development"}' |
N/A | 244 ms | N/A |
| ๐ | benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
N/A | 11.1 ms | N/A |
| ๐ | benchmark "many-chunks-esm", scenario '{"name":"mode-production","mode":"production"}' |
N/A | 2.3 s | N/A |
| ๐ | benchmark "many-modules-commonjs", scenario '{"name":"mode-development","mode":"development"}' |
N/A | 307.9 ms | N/A |
| ๐ | benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
N/A | 10.3 ms | N/A |
| ๐ | benchmark "many-modules-commonjs", scenario '{"name":"mode-production","mode":"production"}' |
N/A | 2.1 s | N/A |
| โ | benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
11.2 ms | 43.5 ms | -74.28% |
| โ | benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' |
23.8 ms | 30.4 ms | -21.74% |
| โ | benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
31.3 ms | 35.2 ms | -10.98% |
| โก | md4 buffer benchmark (size: 10000) |
114.1 ยตs | 73.1 ยตs | +56.18% |
| โก | md4 buffer benchmark (size: 100000) |
447.6 ยตs | 406.7 ยตs | +10.07% |
| โก | md4 buffer benchmark (size: 120) |
76 ยตs | 34.9 ยตs | ร2.2 |
| ... | ... | ... | ... | ... |
:information_source: Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.