webpack.js.org icon indicating copy to clipboard operation
webpack.js.org copied to clipboard

chore(writing-a-loader): added data sharing details

Open anikethsaha opened this issue 5 years ago • 2 comments

describe your changes... Added detailed explanation about how to share data among loaders in writing-a-loader section

anikethsaha avatar Feb 08 '20 13:02 anikethsaha

cc @montogeek I made those changes you suggested 👍

anikethsaha avatar Feb 12 '20 09:02 anikethsaha

Agree that formatting is not necessary, only format violations or clear mistakes (trailing spaces, double quotes in js etc). Additions of newlines or adding trailing commas to snippets is not necessary and only adds overhead in reviewing.

I suggest we simplify the addition into single paragraph of text, i couldnt see second way of doing it even though it stated there are two ways to pass data, please see suggesting and tell me WDYT

I guess I forgot to remove those two ways !! initially I added two ways , the other one was using pitch method. But it seems that's not the ideal recommended way!

I will make those changes you suggested :

PS : Many of those spaces and newline were from prettier ! I guess I forgot to turn that off

anikethsaha avatar Feb 16 '20 15:02 anikethsaha