feat: graceful exit terminal
What kind of change does this PR introduce? feature
Did you add tests for your changes? WIP If relevant, did you update the documentation?
Summary Added code for graceful exit. For reference: https://github.com/webpack/webpack-dev-server/blob/75999bb9bb8803de633fcb037405f45a5bf7d029/lib/Server.js#L1808-L1838
Does this PR introduce a breaking change? Yup can be for tools that consume webpack-cli's output.
Other information /cc @alexander-akait
@alexander-akait should we add flag to enable this behavior as dev server does? If we keep it by default, it can be a breaking change for tools that rely on webpack-cli's output.
Codecov Report
Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 91.48%. Comparing base (
d242dea) to head (9ea48e7). Report is 808 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #3075 +/- ##
==========================================
- Coverage 91.50% 91.48% -0.03%
==========================================
Files 23 23
Lines 1719 1738 +19
Branches 519 524 +5
==========================================
+ Hits 1573 1590 +17
- Misses 146 148 +2
| Files | Coverage Δ | |
|---|---|---|
| packages/webpack-cli/src/webpack-cli.ts | 93.96% <90.00%> (-0.09%) |
:arrow_down: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d242dea...9ea48e7. Read the comment docs.
/cc @alexander-akait