webpack-cli icon indicating copy to clipboard operation
webpack-cli copied to clipboard
verified publisher icon webpack

chore: add pnpm as binary in info

Open rishabh3112 opened this issue 4 years ago • 7 comments

What kind of change does this PR introduce? chore / feat

Did you add tests for your changes? WIP

If relevant, did you update the documentation? N/A

Summary Added pnpm as required binary. Although pnpm isn't supported in envinfo, still this PR has required use case.

Does this PR introduce a breaking change? Nope

Other information

rishabh3112 avatar Jan 05 '22 05:01 rishabh3112

Codecov Report

Merging #3072 (39dd422) into master (754615b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3072   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files          22       22           
  Lines        1615     1615           
  Branches      480      480           
=======================================
  Hits         1532     1532           
  Misses         83       83
Impacted Files Coverage Δ
packages/info/src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 754615b...39dd422. Read the comment docs.

codecov[bot] avatar Jan 05 '22 06:01 codecov[bot]

Tasks

  • Created issue as envinfo for support. (https://github.com/tabrindle/envinfo/issues/216) (Got Approval 🥳 )
  • Create PR at envinfo (PR created : https://github.com/tabrindle/envinfo/pull/224) (Waiting for Merge)
  • Update PR after support is published
  • Add tests
  • Merge

rishabh3112 avatar Jan 05 '22 06:01 rishabh3112

@webpack/cli-team Made a friendly ping on the issue at envinfo. Lets see...

rishabh3112 avatar Mar 31 '22 06:03 rishabh3112

Update: Created PR at https://github.com/tabrindle/envinfo/pull/224

rishabh3112 avatar Apr 11 '22 13:04 rishabh3112

The PR on envinfo has been inactive for a while, and main maintainer is inactive for over a long time given last publish on npm was over a year ago.

image

I guess we can patch it into a fork and deploy it, wdyt @alexander-akait? if yes I will do that.

rishabh3112 avatar May 14 '22 06:05 rishabh3112

@webpack/cli-team One last try I have pinged him on PR, lets see.

rishabh3112 avatar May 14 '22 06:05 rishabh3112

Got a review there, would be working on that now.

rishabh3112 avatar May 30 '22 07:05 rishabh3112