webpack-cli icon indicating copy to clipboard operation
webpack-cli copied to clipboard

feat: create-webpack-app

Open rishabh3112 opened this issue 4 years ago • 9 comments

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

rishabh3112 avatar Nov 29 '21 08:11 rishabh3112

Codecov Report

Merging #3036 (681bf69) into master (66fbf56) will increase coverage by 0.51%. The diff coverage is n/a.

:exclamation: Current head 681bf69 differs from pull request most recent head d1ef790. Consider uploading reports for the commit d1ef790 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
+ Coverage   90.98%   91.50%   +0.51%     
==========================================
  Files          23       23              
  Lines        1731     1719      -12     
  Branches      519      519              
==========================================
- Hits         1575     1573       -2     
+ Misses        156      146      -10     
Impacted Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 94.04% <0.00%> (+0.09%) :arrow_up:
packages/generators/src/index.ts 100.00% <0.00%> (+20.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66fbf56...d1ef790. Read the comment docs.

codecov[bot] avatar Nov 29 '21 09:11 codecov[bot]

Yup sure, will do

rishabh3112 avatar Nov 29 '21 11:11 rishabh3112

@evenstensberg Earlier I described the problem, shorty - when you use npx webpack init, it is not work (try to use it), because webpack-cli is not a part of webpack and npm doesn't install it (so you got not found package error), so we need to use other name, to provide better DX

alexander-akait avatar Dec 04 '21 12:12 alexander-akait

@alexander-akait should we wait for #2862 to get merged here? Reason: It would be a difficult merge else as it has refactors in handler logic as well.

rishabh3112 avatar Dec 14 '21 08:12 rishabh3112

Reviewed :+1:

alexander-akait avatar Dec 14 '21 10:12 alexander-akait

Reviewed 👍

Thanks!

rishabh3112 avatar Dec 15 '21 11:12 rishabh3112

As #2862 is merged, I will continue working on this now!

rishabh3112 avatar Jan 29 '22 03:01 rishabh3112

[Note for self] TODO: Move new templates into create webpack app repo.

rishabh3112 avatar Feb 25 '22 07:02 rishabh3112

@evenstensberg there roadmap for the same currently? If not lets finalize that first. This PR is anyway very old now.

rishabh3112 avatar Nov 28 '23 09:11 rishabh3112