loader-utils icon indicating copy to clipboard operation
loader-utils copied to clipboard

chore: replace deprecated String.prototype.substr()

Open CommanderRoot opened this issue 3 years ago • 2 comments

This PR contains a:

  • [x] bugfix
  • [ ] new feature
  • [x] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Breaking Changes

None

Additional Info

CommanderRoot avatar Mar 18 '22 00:03 CommanderRoot

Codecov Report

Merging #207 (24f1b73) into master (9fe2381) will not change coverage. The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          10       10           
  Lines         360      360           
  Branches      112      112           
=======================================
  Hits          276      276           
  Misses         73       73           
  Partials       11       11           
Impacted Files Coverage Δ
lib/interpolateName.js 95.00% <66.66%> (ø)
lib/getHashDigest.js 89.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fe2381...24f1b73. Read the comment docs.

codecov[bot] avatar Mar 18 '22 11:03 codecov[bot]