loader-utils icon indicating copy to clipboard operation
loader-utils copied to clipboard

feature: stringify loader object - fixes #95

Open peter-spireng opened this issue 3 years ago • 3 comments

At first moment we need agree on API and stringfy result. So, can you please review tests and if they are right, I can add real implementation.

peter-spireng avatar Feb 19 '22 13:02 peter-spireng

Codecov Report

Merging #206 (b140c4e) into master (9fe2381) will increase coverage by 0.50%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   76.66%   77.17%   +0.50%     
==========================================
  Files          10       11       +1     
  Lines         360      368       +8     
  Branches      112      114       +2     
==========================================
+ Hits          276      284       +8     
  Misses         73       73              
  Partials       11       11              
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)
lib/stringifyUseEntries.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fe2381...b140c4e. Read the comment docs.

codecov[bot] avatar Feb 19 '22 13:02 codecov[bot]

Issue #95 is still open with "Help wanted" label, so I thought it is still valid feature request ...

peter-spireng avatar Feb 19 '22 14:02 peter-spireng

We should avoid adding new methods here, if we really need it, we should implement it on webpack side (but I don't think we really need it). We want to deprecated it on the next major release.

And yes, we need to close issues...

alexander-akait avatar Feb 19 '22 14:02 alexander-akait