node-loader icon indicating copy to clipboard operation
node-loader copied to clipboard

chore: replace deprecated String.prototype.substr()

Open CommanderRoot opened this issue 3 years ago • 1 comments

This PR contains a:

  • [x] bugfix
  • [ ] new feature
  • [x] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Breaking Changes

None

Additional Info

CommanderRoot avatar Mar 17 '22 23:03 CommanderRoot

Codecov Report

Merging #65 (2af4f1c) into master (861834c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           12        12           
  Branches         3         3           
=========================================
  Hits            12        12           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 861834c...2af4f1c. Read the comment docs.

codecov[bot] avatar Mar 17 '22 23:03 codecov[bot]