webi-installers icon indicating copy to clipboard operation
webi-installers copied to clipboard

Added the script for creating a docker container with webi for testing

Open y0rune opened this issue 3 years ago • 5 comments

Hello! I have created the PR in this repo. So I decided to create a script for testing Webi in the Docker Container.

If you have any ideas to improve please write.

Thank you!

y0rune avatar Aug 09 '22 08:08 y0rune

@y0rune All of the POSIX changes have been made.

You should be able to test on Docker / alpine now. :)

coolaj86 avatar Aug 21 '22 08:08 coolaj86

Bump @y0rune.

Will you test this now without bash?

coolaj86 avatar Aug 29 '22 03:08 coolaj86

All right I will test it now ;)

y0rune avatar Aug 29 '22 06:08 y0rune

After testing the script it created in the docker container a folder /:/opt/ when I removed from the script the mountpoint in line: https://github.com/webinstall/webi-installers/pull/461/files#diff-b8aed1a937e9424335cd5a4c1ae6e5c5c07e10f2c8ee3d491e05996881a6abeeR40.

So I resolve it today ;)

y0rune avatar Aug 29 '22 08:08 y0rune

Hello! Firstly I will describe how the script worked:

  • Before changes: When I run ./webi-docker.sh without any argument the docker -v "":/opt/ for mounting the volume created folder /:/opt/ image

  • After changes: When I run ./webi-docker.sh without any argument the script for mounting the volume created folder /:/opt/ image

Secondly, I had to disable the SC2046 – Quote this to prevent word splitting. I tried to add in the line 42 the quotes but when I run again the script the docker run -d "" It did not work as should.

Thank you! Marcin

y0rune avatar Aug 29 '22 18:08 y0rune

As far I checked I can not run the alpine linux via my script so I add it into my TODO list and after that I will create another PR. Thank you @coolaj86 ;)

y0rune avatar Oct 01 '22 21:10 y0rune