pyvesync icon indicating copy to clipboard operation
pyvesync copied to clipboard

GitHub actions

Open sdrapha opened this issue 2 years ago • 3 comments

I'm not sure if you are interested on github actions, but I did it anyway. I know there are currently azure-pipelines already there. But the github version of workflows integrates so well both on web interface, app, notifications, etc. so I'm just putting it out there.

It's possible to improve it a bit, breaking out flake8, mypy and pylint in different threads, but for now, just converting the existing azure pipeline structure works well.

sdrapha avatar May 09 '23 02:05 sdrapha

Note that, when I created this PR, all github actions run prrety fast and were completely done (including an extra one python 3.11), and the azure ones hadn't even started yet at that moment. Seems there is a performance difference. Granted that the extra 40 secs of waiting on the azure ones would not hurt anybody though.

sdrapha avatar May 09 '23 03:05 sdrapha

Outside of tests I am a big fan of pre-commit instead of github actions for linting. It auto corrects items it can in the PRs plus consumes the precommit files that VS code uses so just enforces those same items. https://pre-commit.ci/

cdnninja avatar Jan 25 '25 00:01 cdnninja

I think github actions are now used, I suspect this can be closed?

cdnninja avatar Oct 11 '25 20:10 cdnninja