chrome-webcomponents-extension icon indicating copy to clipboard operation
chrome-webcomponents-extension copied to clipboard

Refactors code. State is now reflected via icon (color/greyscale) and title (number of web components).

Open lrsjng opened this issue 11 years ago • 3 comments

Actually I wanted to add the greyscale icon. Now the code is completely refactored. The background script is reduced to communicated with the pageAction icon. The content script is set up to be extendable. Styles are applied via classes and can be switched on/off by setting one trigger class to the html element.

lrsjng avatar Jul 04 '14 16:07 lrsjng

Wasn't meant to be that much change when I forked, feel free to reject if it is too much..

lrsjng avatar Jul 04 '14 16:07 lrsjng

Hey @lrsjng, that's a big rewrite.

I like the idea of the greyscale icon and applying the styles via classes, although I didn't want to do that in the first place because of an extra HTTP request.

If you could separate what matters into small commits that would be much easier to review.

zenorocha avatar Jul 05 '14 12:07 zenorocha

@zenorocha I'm afraid breaking it down into smaller patches won't be possible. There are no incremental steps to update this. background.js and content.js are completely redesigned :/

lrsjng avatar Jul 05 '14 20:07 lrsjng