dynmap icon indicating copy to clipboard operation
dynmap copied to clipboard

support for fabric-1.21.1

Open petersv5 opened this issue 1 year ago • 2 comments

No changes except the usual 1.21 -> 1.21.1 modification. Lightly tested, no issues observed.

petersv5 avatar Aug 16 '24 07:08 petersv5

I've been waiting for this for a month or so now. Any idea when this will be merged?

Ryderbike1 avatar Sep 30 '24 14:09 Ryderbike1

+1, would like to use this for my server.

RealSourceOfficial avatar Oct 12 '24 21:10 RealSourceOfficial

Don't forget to update the version range in the readme table.

What about these errors during the build?

unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)
unknown invokedynamic bsm: java/lang/runtime/SwitchBootstraps/typeSwitch(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)Ljava/lang/invoke/CallSite; (tag=6 iif=false)

I did not even notice these. :-( They are outside of my level of understanding for the mixin system, which is what I assume these messages are from. Any idea how to track them down? As we have not seen any issues since the switch in mid August we have not really looked much into Dynmap build logs since then.

I'm back from travelling abroad and will respond quicker going forward.

petersv5 avatar Oct 22 '24 06:10 petersv5

They are outside of my level of understanding for the mixin system, which is what I assume these messages are from. Any idea how to track them down?

I'd have to google/chatgpt them myself.

ChatGPT wasnt particularily helpful on first try. It points to updating java to 17+ and checking for mixin updates/bug reports.

In the source code it would look like this:

switch (obj) {
            case String s -> System.out.println("It's a string: " + s);
            case Integer i -> System.out.println("It's an integer: " + i);
            case Double d -> System.out.println("It's a double: " + d);
            case null -> System.out.println("It's null");
            default -> System.out.println("It's some other type");
}

Unfortunately I'm not sure if this is part of the replacement source code or if mixin is trying to add a new case into there.

ST-DDT avatar Oct 22 '24 06:10 ST-DDT

Should we close this PR as there are other PRs for 1.21.3 and 1.21.4?

petersv5 avatar Jan 02 '25 08:01 petersv5

Looks good - I'll fix the shadow issue - thanks!

mikeprimm avatar Jan 05 '25 20:01 mikeprimm