DynmapForge icon indicating copy to clipboard operation
DynmapForge copied to clipboard

Issues with webregister - non-responsive login screen

Open AsylumDreams opened this issue 9 years ago • 14 comments

Aloha Running SpongeForge 1.10.2 2171 5.1.0 B 1983 and Dynmap Head Forge 1.10.2 2.4-SNAPSHOT-2080

I can run the command to bring up the code but when it comes to entering it within the prompt screen within the browser, nothing happens when register is clicked.

Config is here if it helps: http://pastebin.com/S0rfTBeu

AsylumDreams avatar Dec 18 '16 14:12 AsylumDreams

Not to be pushy but just on the off-chance that this has fallen by the wayside / is the wrong git ... @mikeprimm

AsylumDreams avatar Dec 20 '16 16:12 AsylumDreams

Same problem here using forge-1.10.2-12.18.3.2254, clicking the register button does nothing.

Victorsueca avatar Mar 10 '17 18:03 Victorsueca

I'm also running into this issue. Using "Dynmap v2.4 for MC 1.10.2 (Forge 12.18.3.2221+)" from CurseForge. When I click the Register button I can see a network request go out, but the response is a 500 Server Error.

DarkMorford avatar Mar 20 '17 18:03 DarkMorford

2.6 for MC 1.12.2 the same problem :(

starhobbit avatar Jan 15 '18 18:01 starhobbit

Same problem. Minecraft 1.12.2, Forge 1.12.2 - 14.23.1.2555, and Dynmap v2.6. Register button won't click.

LockManipulator avatar Jan 17 '18 08:01 LockManipulator

@mikeprimm, Problem is here, you can check bl.getBannedProfile(pid)!=null in return statment

starhobbit avatar Jan 17 '18 22:01 starhobbit

I'm not sure what that means. Do I just insert the line getBannedProfile(pid)!=null in there somewhere?

On Wed, Jan 17, 2018 at 5:55 PM, Alex Starostin [email protected] wrote:

Problem is here https://github.com/webbukkit/DynmapForge/blob/dcb3a5d60003e9842870cabfff9c61a7e1107302/src/main/java/org/dynmap/forge/DynmapPlugin.java#L518, you can check getBannedProfile(pid)!=null

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/webbukkit/DynmapForge/issues/62#issuecomment-358477220, or mute the thread https://github.com/notifications/unsubscribe-auth/AWYLqG1sWFOWXUJLHp0gSgmgSoCu0SCkks5tLnpMgaJpZM4LQJCw .

LockManipulator avatar Jan 18 '18 06:01 LockManipulator

use bl.getBannedProfile(pid)!=null, not bl.isBanned(new GameProfile(null, pid)); in return string

starhobbit avatar Jan 18 '18 19:01 starhobbit

Ah ok thank you!

On Thu, Jan 18, 2018 at 2:33 PM, Alex Starostin [email protected] wrote:

use bl.getBannedProfile(pid)!=null, not bl.isBanned(new GameProfile(null, pid));

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/webbukkit/DynmapForge/issues/62#issuecomment-358756859, or mute the thread https://github.com/notifications/unsubscribe-auth/AWYLqHddxsaOcklHDo331Mr26k0Lf7cWks5tL5yBgaJpZM4LQJCw .

LockManipulator avatar Jan 19 '18 00:01 LockManipulator

I can't seem to find the location of that file to fix it. Where would it be located on my server? I'm using Forge.

On Thu, Jan 18, 2018 at 7:18 PM, jared dygert [email protected] wrote:

Ah ok thank you!

On Thu, Jan 18, 2018 at 2:33 PM, Alex Starostin [email protected] wrote:

use bl.getBannedProfile(pid)!=null, not bl.isBanned(new GameProfile(null, pid));

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/webbukkit/DynmapForge/issues/62#issuecomment-358756859, or mute the thread https://github.com/notifications/unsubscribe-auth/AWYLqHddxsaOcklHDo331Mr26k0Lf7cWks5tL5yBgaJpZM4LQJCw .

LockManipulator avatar Jan 20 '18 05:01 LockManipulator

It's not on your server in this state... You have compilled java (.jar), and that's source code (here on github)... I can't help you to build new jar, because I'm newbe in Java :(

starhobbit avatar Jan 20 '18 11:01 starhobbit

I had to do several things to get this to function.

Commented out lines 693 through 696, lines 712 through 714 and make the above recommended change. Getting it to compile I had to pull down DynmapCore because the dependency information is out of date for gradle. Compiled and it now works.

Dockter avatar Mar 21 '18 05:03 Dockter

Specifically: https://github.com/AlmuraDev/DynmapForge/commit/60bbea3a3e54210f5a9de90f5203d7372c195380

Dockter avatar Mar 21 '18 05:03 Dockter

I think what is causing this is too many GameProfile requests being generated from the same IP address against Mojang's auth servers though I may be off base. I work in the developer environment a ton and I am constantly creating gameProfile calls that get rejected due to too many requests. @mikeprimm would know better, but at least the change I made got the feature working again.

Dockter avatar Mar 21 '18 05:03 Dockter