web3uikit icon indicating copy to clipboard operation
web3uikit copied to clipboard

[Feat]: New Credit card designs

Open AbhinavMV opened this issue 3 years ago • 3 comments


name: 'Pull request' about: Credit card and Credit card radios

New Pull Request

Checklist

  • [x] I am not disclosing a vulnerability.
  • [x] My code is conform the code style
  • [x] I have made corresponding changes to the documentation
  • [x] I have updated Typescript definitions when needed

Issue Description

Related issue: #757

Solution Description

Small credit card radios image

Expired and pressed styles image

new CreditCard2 icon image

AbhinavMV avatar Aug 31 '22 19:08 AbhinavMV

size-limit report 📦

Path Size
packages/core/dist/index.js 261.29 KB (+0.2% 🔺)
packages/icons/dist/index.es.js 61.93 KB (+0.15% 🔺)
packages/web3/dist/index.js 1.43 MB (+0.97% 🔺)
packages/web3uikit/dist/index.js 1.75 MB (+0.78% 🔺)

github-actions[bot] avatar Aug 31 '22 19:08 github-actions[bot]

hey @AbhinavMV it looks good but could you rename the packages/icons/src/lib/icons/CreditCard2.tsx file? It doesn't feel very descriptive in its naming? what do you think?

BillyG83 avatar Sep 12 '22 11:09 BillyG83

hey @AbhinavMV it looks good but could you rename the packages/icons/src/lib/icons/CreditCard2.tsx file? It doesn't feel very descriptive in its naming? what do you think?

Hey @BillyG83 Its a credit card icon file, since we are already using the same name.. the new one has the name as creditcard2 And It is an automatically generated file. Do you have any better naming convention for these types of cases? 🤔

AbhinavMV avatar Sep 12 '22 12:09 AbhinavMV

good job @AbhinavMV

BillyG83 avatar Sep 27 '22 14:09 BillyG83