web3uikit icon indicating copy to clipboard operation
web3uikit copied to clipboard

[Hero] Refactor and match designs

Open BillyG83 opened this issue 3 years ago • 4 comments

Hero has some problems

  • hero should take children components like typography and button and lay them out nicely
  • hero should take an optional component for image
  • Illustration needs updated with this sweet Wizard to be added
  • if the image is added please use the layout seen below
  • do not use position absolute, use flex and give the image a max width and max height
  • it should scale as seen in this design perfectly no matter what content, children or image size is passed
CleanShot 2022-08-01 at 14 24 42@2x

BillyG83 avatar Aug 01 '22 13:08 BillyG83

make it killer DX @AbhinavMV and idiot proof 😁

BillyG83 avatar Aug 01 '22 13:08 BillyG83

Would be great if title is optional too

locothedev avatar Aug 01 '22 13:08 locothedev

@locothedev i think it would be best of you passed it children and an optional image component, then you can use whatever text you like

BillyG83 avatar Aug 01 '22 13:08 BillyG83

@AbhinavMV maybe make the title optional for now and we can remove it over time so there is no big breaking changes

BillyG83 avatar Aug 01 '22 13:08 BillyG83

This is closed by #762

AbhinavMV avatar Sep 27 '22 13:09 AbhinavMV