web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

5087/default common

Open luu-alex opened this issue 3 years ago • 1 comments

Description

#5087 adds defaultcommon to signing and transaction builder. adds maxListenersWarningThreshold and tests

Doc: https://web3js.readthedocs.io/en/v1.7.3/web3-eth.html?highlight=defaultCommon#defaultcommon https://web3js.readthedocs.io/en/v1.7.3/web3-eth-contract.html?highlight=defaultCommon#defaultcommon https://web3js.readthedocs.io/en/v1.7.3/web3-eth.html?highlight=maxListenersWarningThreshold#maxlistenerswarningthreshold

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run dtslint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build with success.
  • [ ] I have tested the built dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • [ ] I have selected the correct 4.x base branch.
  • [ ] Within the description, the feature or issue is discussed in detail or an issue is linked.
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have added any required tests for the changes I made
  • [ ] I have made corresponding changes to the documentation
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran yarn successfully
  • [ ] I ran yarn lint successfully
  • [ ] I ran yarn build:web successfully
  • [ ] I ran yarn test:unit successfully
  • [ ] I ran yarn test:integration successfully
  • [ ] I ran compile:contracts successfully
  • [ ] I have tested my code.
  • [ ] I have updated the corresponding CHANGELOG.md file in the packages I have edited.

luu-alex avatar Sep 07 '22 06:09 luu-alex

Your Render PR Server URL is https://web3js-docs-pr-5419.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ccc3dmirrk0bvdi3tfgg.

render[bot] avatar Sep 07 '22 06:09 render[bot]