web3.js
web3.js copied to clipboard
Added missing return statement for web3-providers-http
Description
Added missing return statement for web3-providers-http, which is under the catch block.
( Might not be very important for someone using promise like me, but would fix the callback calling error twice )
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
Checklist:
- [x] I have selected the correct base branch.
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] I have made corresponding changes to the documentation.
- [x] My changes generate no new warnings.
- [x] Any dependent changes have been merged and published in downstream modules.
- [x] I ran
npm run dtslintwith success and extended the tests and types if necessary. - [x] I ran
npm run test:covand my test cases cover all the lines and branches of the added code. - [x] I ran
npm run buildwith success. - [x] I have tested the built
dist/web3.min.jsin a browser. - [x] I have tested my code on the live network.
- [x] I have checked the Deploy Preview and it looks correct.
- [x] I have updated the
CHANGELOG.mdfile in the root folder.
Pull Request Test Coverage Report for Build 2727583403
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+0.004%) to 74.603%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| packages/web3-providers-http/lib/index.js | 1 | 77.36% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 2697072063: | 0.004% |
| Covered Lines: | 3270 |
| Relevant Lines: | 4132 |