web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

Added missing return statement for web3-providers-http

Open ayanamidev opened this issue 3 years ago • 1 comments

Description

Added missing return statement for web3-providers-http, which is under the catch block.

( Might not be very important for someone using promise like me, but would fix the callback calling error twice )

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] I have selected the correct base branch.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [x] Any dependent changes have been merged and published in downstream modules.
  • [x] I ran npm run dtslint with success and extended the tests and types if necessary.
  • [x] I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • [x] I ran npm run build with success.
  • [x] I have tested the built dist/web3.min.js in a browser.
  • [x] I have tested my code on the live network.
  • [x] I have checked the Deploy Preview and it looks correct.
  • [x] I have updated the CHANGELOG.md file in the root folder.

ayanamidev avatar Jul 24 '22 14:07 ayanamidev

Pull Request Test Coverage Report for Build 2727583403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 74.603%

Files with Coverage Reduction New Missed Lines %
packages/web3-providers-http/lib/index.js 1 77.36%
<!-- Total: 1
Totals Coverage Status
Change from base Build 2697072063: 0.004%
Covered Lines: 3270
Relevant Lines: 4132

💛 - Coveralls

coveralls avatar Jul 24 '22 14:07 coveralls