interop icon indicating copy to clipboard operation
interop copied to clipboard

Drop html/semantics/popovers/popover-top-layer-interactions.html

Open nt1m opened this issue 1 year ago • 4 comments

Test List

https://wpt.fyi/results/html/semantics/popovers/popover-top-layer-interactions.html?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2024-popover

Rationale

This seems to be timing out in Safari just because of a fullscreen subtest, which passes in WebKitTestRunner: https://searchfox.org/wubkat/rev/3dea3f050e72b74b587cf5f4943a60c7b5cb5452/LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-interactions-expected.txt#10

This suggests some kind of issue with SafariDriver and fullscreen, which either way are out-of-scope for the popover focus area.

Another option could be splitting out that subtest, though I don't think it's worth the trouble given everything else passes everywhere.

@foolip @jgraham What do you think?

nt1m avatar Jul 21 '24 07:07 nt1m

@nt1m have you debugged which step of the test the timeout happens? Does it happen even if all of the preceding tests are removed?

Fullscreen and popover are related through their use of top layer, so I think this case is a bit different from ones where an unrelated feature is used in a test. It would be good at least know what the bug is, to be sure it's a SafariDriver or fullscreen bug, not a popover bug.

foolip avatar Jul 24 '24 15:07 foolip

@foolip This subtest tries to open a fullscreen element followed by another one, and it times out trying to open the second one.

FWIW, I'm 100% sure it's unrelated to popover, since all the popover tests successfully run before that (the specific failing subtest is the last one, so none of the other ones are blocked by this one).

nt1m avatar Jul 25 '24 17:07 nt1m

This might solve the issue on the WebKit side, but I'm not sure: https://github.com/WebKit/WebKit/commit/f62c0edfc546848f8711146ce8a0a90d1c00ace4

Essentially drops the user gesture requirement for entering fullscreen in WebDriver, in favor of the normal transient activation one. I'll have to wait for next STP to come out to check.

nt1m avatar Jul 27 '24 02:07 nt1m

This might solve the issue on the WebKit side, but I'm not sure: https://github.com/WebKit/WebKit/commit/f62c0edfc546848f8711146ce8a0a90d1c00ace4

It didn't, I'm still puzzled why this passes in WebKit Test Runner but not SafariDriver...

@foolip If you look at the breakdown of the subtests, it's really just the "stack 2 fullscreen elements" subtest failing: https://wpt.fyi/results/html/semantics/popovers/popover-top-layer-interactions.html?label=experimental&label=master&aligned&view=interop&q=label%3Ainterop-2024-popover

which is unrelated to popover.

nt1m avatar Aug 17 '24 08:08 nt1m

I guess we can close this now?

zcorpan avatar Feb 17 '25 22:02 zcorpan

Closing this as per consensus

nairnandu avatar Feb 20 '25 17:02 nairnandu