weaviate-python-client icon indicating copy to clipboard operation
weaviate-python-client copied to clipboard

Fix config schema with multivector

Open robbespo00 opened this issue 11 months ago • 2 comments

This PR fixes a small bug when exporting the config of the collections.

Multivector config was reported twice in the collection config even if multivector flag was not enabled.

How to reproduce it

Create a simple python collection as follows:

collection = client.collections.create(
    name="Article",
)
config = client.collections.export_config(
        "Article"
    ).to_dict()

Looking at the config values you will see multivector config twice even though multivector was not enabled.

robbespo00 avatar Feb 28 '25 14:02 robbespo00

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.24%. Comparing base (7987de5) to head (21c3a4a). Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1573      +/-   ##
==========================================
+ Coverage   88.17%   88.24%   +0.07%     
==========================================
  Files         256      256              
  Lines       17677    17678       +1     
==========================================
+ Hits        15586    15600      +14     
+ Misses       2091     2078      -13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Feb 28 '25 15:02 codecov-commenter

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

weaviate-git-bot avatar Mar 01 '25 10:03 weaviate-git-bot