weave-gitops icon indicating copy to clipboard operation
weave-gitops copied to clipboard

Add analytics to helm chart on dashboard installation

Open joshri opened this issue 3 years ago • 1 comments

Closes #2771

When creating the Helm Chart for the dashboard, we will now check the user's config file and set analytics accordingly

joshri avatar Oct 13 '22 17:10 joshri

:no_entry: This version of this doesn't work because it's passing nil as the logger. However when rebased on top of #2868 so the logger isn't needed, it seems to work :+1:

ozamosi avatar Oct 14 '22 11:10 ozamosi

@ozamosi I've

  • added the global sessionConfig var to be able to set it for unit testing.
  • fixed the helm release and values unit tests.
  • fixed text messages and prompt (which was worse because it just hang the terminal) being forwarded to generated dashboard manifests if the create dashboard with --export flag on was the first command (before the analytics config was created) when running the GitOps CLI.

opudrovs avatar Nov 24 '22 02:11 opudrovs

Tested it, seems to work as expected.

opudrovs avatar Nov 24 '22 02:11 opudrovs

This should be merged before the enterprise PRs.

opudrovs avatar Nov 24 '22 03:11 opudrovs