weave-gitops icon indicating copy to clipboard operation
weave-gitops copied to clipboard

Multi-column text search

Open joshri opened this issue 3 years ago • 0 comments

Short description Users should be able to text search on multiple columns - here's @ozamosi in #2714 :

"...The text filters seem like they should be ANDed based on the tests, so I'm going to assume that's correct.

To make this work properly, I think we need to:

First (inner-most) OR each field together - any field that matches a single text filter means that the whole row matches that filter. Then, AND the filters together. And only then do we decide if the row as a whole matches the filters as a whole. We're currently merging the filters before we're merging the columns, which I think doesn't work properly with multiple textSearchable columns - if again name and namespace are searchable, you wouldn't get a hit if one filter matches name and one filter matches namespace, only if all filters matches either name or namespace."

I'm absolutely 100% confused on the specifics of how we want this working so - TO BE WORKED OUT IN REFINEMENT:

  • Which/how many columns should be textSearchable on all tables? Name and namespace? Cluster for enterprise?
  • I'm lost in AND / OR. Will the filter have to match in all searchable columns or just one?
  • @opudrovs made a good point about notifying the user. If the user is expecting to search by name it'll be strange when certain rows show up based on their search matching the namespace. Right now we tell them absolutely nothing, so there's that.

joshri avatar Sep 12 '22 13:09 joshri