weaveworks
Highlight the search query matches in table view
To make the search behaviour consistent between Graph and Table views, we should probably highlight the matches based on the search query in both views. Pinned terms could still be used only for filtering and not be highlighted (like is the case right now in Graph view).
Hi @fbarl, I am new to this project. I have looked through the contributing guidelines, set up the development environment and would love to work on this issue.
Regarding this issue, I found:
- In the Table view, we filter out the results presenting only those which match the search filter.
- In Graph view, we highlight the results and grey out the remaining ones.
We want to achieve the same highlighting behavior in the table view without changing any other behavior, right?
Hi @psinghal20, thanks for taking interest in this issue!
As you've pointed out, search filtering currently differs between Table & Graph view in two ways:
- In Graph view the nodes not matched by the (non-pinned) search query are grayed out, while in Table view they are completely hidden
- In Graph view there is a blue highlight on the text chunks matched by the search query, while in Table view they're absent
This issue is only supposed to address point 2 by introducing the same blue highlight in Table view as it currently exists in Graph view. So yes, the change should only affect the Table view mode.
@fbarl I'd like to take a shot at this and add the highlight. Creating the PR now.
