variable 'domain' name conflict resolved

Open lnyarl opened this issue 12 years ago • 2 comments

EventEmitter has variable named 'domain'. So, 'domain' in smtp.js is convert to 'domainName'

Mar 12 '13 06:03 lnyarl

Would it be possible to merge this commit? It seems pretty harmful and it would be great to be able to use this module with recent node versions.

Sep 05 '13 08:09 pjparra

@pjparra you can merge as fast-forward. I modify just variable name to this.domainName from this.domain and It works. I don't know that any problem in my commit.

2013-10-19 9 03 19

This screen shot is merge message in my local repo.

Sorry for my bad english.

Oct 19 '13 12:10 lnyarl