node-mail icon indicating copy to clipboard operation
node-mail copied to clipboard

this.domain causes failure since node 0.8.8 uses a domain field on EventEmitter

Open richtera opened this issue 13 years ago • 1 comments

Seems that event emitters in node 0.8.8 have a domain member that conflicts with your usage of domain. There is a problem in events.js at line:

events.js:80 this.domain.enter(); ^ TypeError: Object has no method 'enter'

where is the local hostname of my machine. I see in your code you're defining the domain to be either the passed in domain value or OS.hostname().

richtera avatar Sep 17 '12 15:09 richtera

Thanks for the info, richtera. I've created a pull request to patch it: https://github.com/weaver/node-mail/pull/25. I just did s/domain/domainName/g on the module. I don't know if it's the best solution or not (it does break backward compatibility a bit), but it was my quick and dirty way to make the module usable again.

huetsch avatar Nov 28 '12 20:11 huetsch