eftest icon indicating copy to clipboard operation
eftest copied to clipboard

Increase test coverage for `:fail-fast`?

Open vemv opened this issue 4 years ago • 11 comments

This will help reliably coming up with a fix for https://github.com/weavejester/eftest/issues/75.

Coverage is extended by:

  • providing counterexamples for each test case
  • also exercising exception handling, whether it happens in the deftest body, or in fixtures.

vemv avatar Oct 07 '21 11:10 vemv

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

  • The commit message should not contain markdown.
  • The commit message body has a line over 72 characters.

atomist[bot] avatar Oct 07 '21 11:10 atomist[bot]

The commit message should not contain markdown.

Are you on board with this one? Some months ago GH added pretty rendering for markdown in various places of the UI, which invites one to create less ambiguous communication:

image

vemv avatar Oct 07 '21 11:10 vemv

(Fat-fingered the close button)

vemv avatar Oct 07 '21 11:10 vemv

Thanks for the review! It's ready again.

vemv avatar Oct 09 '21 16:10 vemv

Ready again!

vemv avatar Oct 13 '21 08:10 vemv

(ping)

vemv avatar Oct 19 '21 21:10 vemv

Sorry for the delay. It looks fine - can you squash down your commits?

weavejester avatar Oct 19 '21 21:10 weavejester

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

  • The commit message should not contain markdown.
  • The commit message body has a line over 72 characters.

atomist[bot] avatar Oct 19 '21 22:10 atomist[bot]

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

  • The commit message should not contain markdown.

atomist[bot] avatar Oct 22 '21 09:10 atomist[bot]

The commit message body has a line over 72 characters.

Satisfied

The commit message should not contain markdown.

Left as-is see https://github.com/weavejester/eftest/pull/85#issuecomment-937713217

vemv avatar Oct 22 '21 09:10 vemv

The commit message should not contain markdown.

Are you on board with this one? Some months ago GH added pretty rendering for markdown in various places of the UI, which invites one to create less ambiguous communication:

I'd prefer plaintext, please. Not all git log viewers support markdown. So a better commit message might be:

Increase test coverage for :fail-fast option

Coverage is extended by checking exceptions and the base case when
:fail-fast is false.

You also mention #75 in the commit message, but these tests pass, don't they? How do you see them helping with that issue?

weavejester avatar Oct 22 '21 12:10 weavejester