W. David Dagenhart

Results 91 comments of W. David Dagenhart

All the test failures are unrelated to this PR. Except for the following the tests are passing. The unit test test_TkHistoMap is already failing in the IBs. Comparison differences: 12834.7...

The only change in a simulation package is adding 1 line to add a missing #include of a header file (previously was indirectly included by another header).

please test The unit test already failing in the IBs was fixed a couple IBs ago so lets rerun to get this one green.

please test This should resolve all the comments and questions received so far. Let me know if there are any more.

please test Includes the added comment that was requested. Squashed commits. This should resolve all the comments and questions received so far.

I'll start reviewing this tomorrow.

+1 Logic looks good. Just the one minor comment I just submitted. Overall, looks good now.