WavesGUI icon indicating copy to clipboard operation
WavesGUI copied to clipboard

[FEATURE] Build compatibility with Windows

Open xucito opened this issue 6 years ago • 2 comments

Аbstract Is your feature request related to a problem? Please describe.

Build scripts only work for Linux/Mac environments

i.e. package.json

  "scripts": {
    "start": "ts-node server.ts startSimple openUrl",
    "preinstall": "sh scripts/preinstall.sh",
    "postinstall": "sh scripts/postinstall.sh",
    "preversion": "sh scripts/preversion.sh",
    "postversion": "sh scripts/postversion.sh",
    "lessc": "sh scripts/lessc",
    "build": "tsc -p ./tsconfig.json && gulp all",
    "server": "npm run build && ts-node server.ts",
    "electron:linux": "electron-packager ./dist/desktop/mainnet/ --icon=./electron/icons/icon.png --platform=linux --out=./dist/linux",
    "electron:win": "electron-packager ./dist/desktop/mainnet/ --icon=./electron/icons/icon.ico --platform=win32 --out=./dist/win",
    "electron:osx": "electron-packager ./dist/desktop/mainnet/ --icon=./electron/icons/icon.icns --platform=darwin --out=./dist/osx",
    "electron": "tsc -p ./tsconfig.json && gulp all && npm run electron:linux && npm run electron:win && npm run electron:osx",
    "electron-debug": "gulp electron-debug && node_modules/.bin/electron dist/desktop/electron-debug/ --ignore-ssl-error --no-replace-desktop --inspect",
    "data-services": "gulp data-services"
  }

Motivation and Purposes A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]. Enable development against windows workstation for more developer engagement

** Specification** A clear and concise description of what you want to happen. Describe alternatives you've considered

Update build scripts to be compatible with windows environments.

Backwards Compatibility Can your proposition affect any existing features?

No

Examples and Implementation Examples of implementation in other projects?

xucito avatar Jan 21 '20 18:01 xucito

Workaround for developing this project via Windows is using git bash shell as the script-shell for npm

npm config set script-shell "<path to bash.exe>"

e.g.

npm config set script-shell "C:\Program Files\Git\git-bash.exe"

Dependency however is git must be installed.

xucito avatar Jan 21 '20 21:01 xucito

There is working version for Waves Lite Wallet

weidisu avatar Feb 05 '21 14:02 weidisu