command-group

command-group copied to clipboard

"blocking waitpid returned pid=0" from `AsyncGroupChild::wait`

5

Seems to be a cancel safety issue, this happens when i `wait()` with a timeout and then `wait()` again: This reproducer: ```rust use command_group::AsyncCommandGroup; use tokio::process::Command; #[tokio::main] async fn main()...

9999years

Possible soundness issue in ChildImp::wait

1

While conducting an internal unsafe review, we identified a possible soundness issue in `ChildImp::wait` https://github.com/watchexec/command-group/blob/b88296fed10b18aebb7ad5889dab5e43b621297f/src/tokio/child/windows.rs#L100-L104 This function and the one below call the `Clone` impl that appears to undermine the...

gigaroby

Possible soundness issue in JobPort::Drop

1

While conducting an internal unsafe review, we identified a possible soundness issue in `JobPort::Drop` https://github.com/watchexec/command-group/blob/b88296fed10b18aebb7ad5889dab5e43b621297f/src/winres.rs#L35 This is highly suspect when combined with `#[derive(Clone)]` on the struct: any use of Clone...

gigaroby

Use `tokio::Command::process_group` whjen stablised?

1

tokio-rs/tokio#6731 it seems that `tokio::Command::process_group` is going to be stablised pretty soon.

NobodyXu