workflows icon indicating copy to clipboard operation
workflows copied to clipboard

fix workflow - find files not containing a string

Open drecali opened this issue 3 years ago • 0 comments

Discord username: Andrei 𓄁#5107

Description of changes (updated or new workflows)

The original workflow was a bit misleading and caused an error if it was run as-is. It used string and pattern interchangeably. Here are the issues:

  • the pattern argument is placed where the pathname/directory argument should be. This leads to an error because grep tries to look in the pattern directory or file and can't find it.

    Screen Shot 2022-06-22 at 20 53 49 Screen Shot 2022-06-22 at 20 55 23
  • it hardcoded the string "foo" instead of making it an argument.

Here are my changes in a local version of Warp. Screen Shot 2022-06-22 at 20 53 34

Questions

  1. Is the mix of single and double quotes OK? It seems to be OK according to the YAML docs linked by FORMAT.md. I can use escaped double quotes if needed.
  2. Is the wording OK? My goal was to be consistent and not use 2 terms interchangeably.
  3. Is it better if the directory argument has a default of * for the current directory?

drecali avatar Jun 22 '22 12:06 drecali