expression-search icon indicating copy to clipboard operation
expression-search copied to clipboard
verified publisher icon wangvisual

German Translation

Open loilo opened this issue 7 years ago • 5 comments

I'm loving to use this addon in English, but I'd also love to install it for my parents who basically don't speak English at all. As a native German speaker I'd love to attach a PR with a German translation of this addon. Would that be ok? 😊

loilo avatar Jul 04 '18 10:07 loilo

Sure, Thanks!

wangvisual avatar Jul 04 '18 15:07 wangvisual

Awesome. 👍

There are two things I need to know though:

  1. What is required to create a translation? Simply duplicating the en-US folder to de-DE and adding an according entry in chrome.manifest just made the add-on dysfunctional. However, it was probably not because of my changes in the ExpressionSearch.properties file, I copied its contents into the en-US translation and it worked like a charm there.
  2. Also, I'm not able to produce a working .xpi from the repo's master branch (for Thunderbird 52). Downloading a current release, unpacking, modifying and re-packing it works though.

Any tips here?

loilo avatar Jul 04 '18 21:07 loilo

  1. The steps are correct, just copy and add one entry should works.
  2. Check the release.bat, make changes if you don't use 7zip, but the issue is the master branch is under ongoing re-work to make it works with TB60, which changes a lot compare with TB52.

wangvisual avatar Jul 08 '18 15:07 wangvisual

I've added de-DE placeholders.

wangvisual avatar Jul 08 '18 15:07 wangvisual

Thanks, I'll take a look.

For my parents I've already translated a current XPI, but that included some more work like localizing the search keywords and adjusting date parsing to German.

However that would probably be a too broad scope for just a localization. I'll just attach the German localization here file whenever I'll find the time. 🙂

loilo avatar Jul 08 '18 15:07 loilo