ScriptCraft icon indicating copy to clipboard operation
ScriptCraft copied to clipboard

add https module

Open jfmherokiller opened this issue 8 years ago • 3 comments

This commit adds a basic https module based off the http one allowing Javascript to make https requests in addition to http ones

jfmherokiller avatar Oct 11 '17 16:10 jfmherokiller

Is this supposed to work ? Trying the following simple code

var https = require('https');
https.require('https://google.fr');

Gives me the following error :

[23:35:57 WARN]: [scriptcraft] Plugin scriptcraft v3.2.1-2016-12-23 generated an exception while executing task 6532
jdk.nashorn.internal.runtime.ECMAException: TypeError: Can not create new object with constructor javax.net.ssl.HttpsURLConnection with the passed arguments; they do not match any of its method signatures.
        at jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57) ~[nashorn.jar:?]
        at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:213) ~[nashorn.jar:?]
        at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:185) ~[nashorn.jar:?]
        at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:172) ~[nashorn.jar:?]
        at jdk.nashorn.internal.runtime.linker.NashornStaticClassLinker.checkNullConstructor(NashornStaticClassLinker.java:108) ~[nashorn.jar:?]
        at jdk.nashorn.internal.runtime.linker.NashornStaticClassLinker.getGuardedInvocation(NashornStaticClassLinker.java:88) ~[nashorn.jar:?]
        at jdk.internal.dynalink.support.CompositeTypeBasedGuardingDynamicLinker.getGuardedInvocation(CompositeTypeBasedGuardingDynamicLinker.java:176) ~[nashorn.jar:?]
        at jdk.internal.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:124) ~[nashorn.jar:?]
        at jdk.internal.dynalink.support.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:154) ~[nashorn.jar:?]
        at jdk.internal.dynalink.DynamicLinker.relink(DynamicLinker.java:253) ~[nashorn.jar:?]
        at jdk.nashorn.internal.scripts.Script$Recompilation$1788$2941$\^eval\_.L:1#request#L:90(<eval>:108) ~[?:?]
        at jdk.nashorn.javaadapters.java.lang.Runnable.run(Unknown Source) ~[?:?]
        at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:71) ~[spigot-1.12.1.jar:git-Spigot-da42974-8f47214]
        at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [spigot-1.12.1.jar:git-Spigot-da42974-8f47214]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_144]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_144]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
>```

On a sidenote, HTTPS requests work for me w/ the HTTP module, if I use openJDK and not oracle JDK.

Gloorf avatar Oct 16 '17 21:10 Gloorf

@Gloorf sorry i forgot to cast the string

jfmherokiller avatar Oct 19 '17 17:10 jfmherokiller

@jfmherokiller I still have the same error as @Gloorf with your latest commit:

[01:53:07 WARN]: [scriptcraft] Plugin scriptcraft v3.4.0-2019-01-20 generated an exception while executing task 26735
jdk.nashorn.internal.runtime.ECMAException: TypeError: Can not create new object with constructor javax.net.ssl.HttpsURLConnection with the passed arguments; they do not match any of its method signatures.
at jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57) ~[nashorn.jar:?]
at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:213) ~[nashorn.jar:?]
at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:185) ~[nashorn.jar:?]
at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:172) ~[nashorn.jar:?]
at jdk.nashorn.internal.runtime.linker.NashornStaticClassLinker.checkNullConstructor(NashornStaticClassLinker.java:108) ~[nashorn.jar:?]
at jdk.nashorn.internal.runtime.linker.NashornStaticClassLinker.getGuardedInvocation(NashornStaticClassLinker.java:88) ~[nashorn.jar:?]
at jdk.internal.dynalink.support.CompositeTypeBasedGuardingDynamicLinker.getGuardedInvocation(CompositeTypeBasedGuardingDynamicLinker.java:176) ~[nashorn.jar:?]
at jdk.internal.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:124) ~[nashorn.jar:?]
at jdk.internal.dynalink.support.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:154) ~[nashorn.jar:?]
at jdk.internal.dynalink.DynamicLinker.relink(DynamicLinker.java:253) ~[nashorn.jar:?]
at jdk.nashorn.internal.scripts.Script$Recompilation$4154$2942$\^eval\_.L:1#request#L:91(<eval>:109) ~[?:?]
at jdk.nashorn.javaadapters.java.lang.Runnable.run(Unknown Source) ~[?:?]
at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:76) ~[server.jar:git-Spigot-79a30d7-acbc348]
at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [server.jar:git-Spigot-79a30d7-acbc348]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_191]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_191]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]
```

unixfox avatar Apr 16 '19 00:04 unixfox