Changes to allow cylinders - and other cuboids - to go down

[kellyfj]

Hi Walter,

I was trying to create a new function like cylinder.js but that would create a hole in the ground. I traced cylinder --> arcImpl down to traverseHeight and noticed I could not pass a negative height in.

Would love some feedback on whether this approach makes sense or if you would do something different.

With this change I can now do /js cylinder(blocks.air,5,-40)

to make a hole with radius 5 and 40 blocks deep

Best,

-Frank

[walterhiggins]

Hey @kellyfj ,

If you want to build down, then why not move down first then build up?

/js down(40).cylinder(blocks.air,5,40)

[walterhiggins]

hmmm. I think I see what you mean - you can do it by moving the drone first but using negative values for width, height and depth is more concise. I'll look at this some more.

[walterhiggins]

I reckon if we go this route (negative distances) we'll have to do it for height, width and depth and update the docs accordingly. Will have a think about it.