MultiAssayExperiment icon indicating copy to clipboard operation
MultiAssayExperiment copied to clipboard

`na.rm` argument in `subsetByColData`

Open gogonzo opened this issue 4 years ago • 4 comments

Referring to the discussion in https://github.com/waldronlab/MultiAssayExperiment/issues/303 Please allow user to specify na.rm in subsetByColData to return data without any errors when column contains NAs

library(MultiAssayExperiment)
subsetByColData(miniACC, DF$race == "white") # error
subsetByColData(miniACC, DF$race == "white", na.rm = TRUE) # to return a MAE without rows having NA in the condition

Thank you, Dawid K

gogonzo avatar Nov 08 '21 10:11 gogonzo

Thanks. We will update accordingly, depending on the result of the DataFrame issue https://github.com/Bioconductor/S4Vectors/issues/92.

LiNk-NY avatar Nov 08 '21 15:11 LiNk-NY

Can na.rm be TRUEby default then - to keep it consistent with the MAE from Bioc < 3.14?

gogonzo avatar Nov 12 '21 12:11 gogonzo

If this gets resolved in DataFrame, this option will not be needed.

LiNk-NY avatar Nov 12 '21 16:11 LiNk-NY

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 17 '22 05:04 stale[bot]