bls icon indicating copy to clipboard operation
bls copied to clipboard

Implement BLS crypto type for Substrate

Open drskalman opened this issue 4 years ago • 3 comments

Substrate requires a crypto type similar to: https://github.com/paritytech/substrate/blob/master/primitives/application-crypto/src/ecdsa.rs to be able to instantiate a signer for beefy capable of bls sigining. Implementing such crypto types help implementers to kick off BLS on beefy.

drskalman avatar Dec 07 '21 21:12 drskalman

This is related to: https://github.com/paritytech/substrate/issues/10469

drskalman avatar Dec 13 '21 16:12 drskalman

2912fa1b1b implements BLS Signature core crypto. Remains to make the tests compile and pass

It is also not clear for me what to set the context for the messages before they get signed in:

sig.verify(Message::new(b"ctx", message.as_ref()), &public_key)

It is abscent for ed25519 crypto. @burdges, @AlistairStewart?

drskalman avatar May 26 '22 22:05 drskalman

The (draft) pull request is ready: https://github.com/paritytech/substrate/pull/11574 searching for some reviewer now.

All bls crypto test pass.

uint::tests::test_u256 fails for some strange reason:

failures:

---- uint::tests::test_u256 stdout ----
thread 'uint::tests::test_u256' panicked at 'called `Result::unwrap_err()` on an `Ok` value: 16', primitives/core/src/uint.rs:61:5

drskalman avatar Jun 01 '22 22:06 drskalman