openscreenprotocol icon indicating copy to clipboard operation
openscreenprotocol copied to clipboard
verified publisher icon w3c

Fixes algorithm and signing fields in agent certificate.

Open markafoltz opened this issue 4 years ago • 2 comments

Addresses:

  • Issue #279: The keyUsage name is digitalSignature, not signing
  • Issue #280: Clarify the supported signature algorithms for certificates

For the first item, it explicitly references the keyUsage bit for digitalSigning.

For the second item, I added a table that matches the TLS signature_scheme values to the AlgorithmIdentifier values that should be used in the certificate.

Preview | Diff

Preview | Diff

markafoltz avatar Oct 27 '21 06:10 markafoltz

@tidoust @chrisn Please take a look to ensure this makes sense and formatting is OK, then I will bring in Ryan to take a look as well.

markafoltz avatar Oct 27 '21 06:10 markafoltz

I believe this PR is still ready for review. We can review it next week as it's been open a while.

markafoltz avatar Sep 07 '22 21:09 markafoltz

I have gone ahead and filled in the fields for secp384r1 and ecdsa-with-SHA384. Please take a look to see if you have any additional comments.

markafoltz avatar Nov 10 '22 01:11 markafoltz

Tagging @tidoust in case he didn't see my last comment :)

markafoltz avatar Nov 11 '22 00:11 markafoltz