node-docker-machine icon indicating copy to clipboard operation
node-docker-machine copied to clipboard
verified publisher icon vweevers

Fix to support args without values

Open SkeLLLa opened this issue 6 years ago • 4 comments

Fix to support args without values.

SkeLLLa avatar Jan 03 '20 14:01 SkeLLLa

Can you give an example of an arg/option where this is a problem?

vweevers avatar Jan 03 '20 14:01 vweevers

@vweevers it can be any "boolean" argument that docker-machine driver consumes. E.g. --amazonec2-request-spot-instance

SkeLLLa avatar Jan 03 '20 15:01 SkeLLLa

Wouldn't options[key] be true in that case? 🤔

Perhaps we should replace the options object with an args array. That way you can pass in anything and node-docker-machine wouldn't have to translate.

vweevers avatar Jan 03 '20 18:01 vweevers

In case of true it should be "true" to get it work with aws driver. But other drivers may have issues.

SkeLLLa avatar Jan 03 '20 19:01 SkeLLLa