Vincent Weevers

Results 332 comments of Vincent Weevers

Please continue further discussion about `nosql-leveldb` in its own repo.

No news. If there was, you would have seen a comment or cross-reference here. PR is welcome.

@dependabot squash and merge

Thanks for reaching out! Previous discussions: - https://github.com/Level/levelup/issues/15 - https://github.com/Level/levelup/issues/138 TLDR: there hasn't been a compelling use case for exposing snapshots. Can you share yours? :) Regarding "multiple get calls":...

See also https://github.com/Level/levelup/issues/491#issuecomment-331094818

> And the implementation is probably quite simple, at least for the LeveDOWN backend. *at least for the LeveDOWN backend* is exactly right 😉

> otherwise it's pretty hard to achieve the consistency requirement I'd like to hear *why* the consistency is required. Often it's perfectly fine to do: ```js db.createValueStream().on('data', key => {...

> The most compelling argument for exposing snapshots might be that many users won't actually spend too much thinking on possible inconsistencies when seeing code like the one I posted...

@peakji just curious: why did you make this edit to your comment: > ~~I think the performance should be identical.~~

> @peakji: AFAIK, we didn't mention snapshot/consistency in levelup. => https://github.com/Level/levelup/issues/590